Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-ocm-2.10] MGMT-19017: Handle skipping hostPrefix validation for IPv6 #6805

Open
wants to merge 1 commit into
base: release-ocm-2.10
Choose a base branch
from

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #6054

/assign carbonin

…-OVN/SDN networkTypes, the hostPrefix validation is not required and it is skipped. This fixes a regression introduced in the fix for https://issues.redhat.com/browse/OCPBUGS-23069 in which IPv6 CIDRs were not using the correct default hostPrefix. In addition, all cases where the validation is used are now covered.
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Could not make automatic cherrypick of Jira Issue OCPBUGS-30232 for this PR as the target version is not set for this branch in the jira plugin config. Running refresh:
/jira refresh

/retitle [release-ocm-2.10] : Handle skipping hostPrefix validation for IPv6

In response to this:

This is an automated cherry-pick of #6054

/assign carbonin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 25, 2024
@openshift-ci-robot
Copy link

@openshift-ci-robot: This pull request references Jira Issue OCPBUGS-30232, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Done-Errata) instead
  • expected Jira Issue OCPBUGS-30232 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

@openshift-cherrypick-robot: Could not make automatic cherrypick of Jira Issue OCPBUGS-30232 for this PR as the target version is not set for this branch in the jira plugin config. Running refresh:
/jira refresh

/retitle [release-ocm-2.10] : Handle skipping hostPrefix validation for IPv6

In response to this:

This is an automated cherry-pick of #6054

/assign carbonin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@carbonin carbonin changed the title [release-ocm-2.10] OCPBUGS-30232: Handle skipping hostPrefix validation for IPv6 [release-ocm-2.10] MGMT-19017: Handle skipping hostPrefix validation for IPv6 Sep 25, 2024
@openshift-ci openshift-ci bot changed the title [release-ocm-2.10] MGMT-19017: Handle skipping hostPrefix validation for IPv6 [release-ocm-2.10] : Handle skipping hostPrefix validation for IPv6 Sep 25, 2024
@openshift-ci-robot openshift-ci-robot removed jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 25, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 25, 2024

@openshift-cherrypick-robot: This pull request references MGMT-19017 which is a valid jira issue.

In response to this:

This is an automated cherry-pick of #6054

/assign carbonin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 25, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

This is an automated cherry-pick of #6054

/assign carbonin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@carbonin carbonin changed the title [release-ocm-2.10] : Handle skipping hostPrefix validation for IPv6 [release-ocm-2.10] MGMT-19017: Handle skipping hostPrefix validation for IPv6 Sep 25, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 25, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 25, 2024

@openshift-cherrypick-robot: This pull request references MGMT-19017 which is a valid jira issue.

In response to this:

This is an automated cherry-pick of #6054

/assign carbonin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 25, 2024
Copy link

openshift-ci bot commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign danmanor for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.30%. Comparing base (3b411e6) to head (630e21d).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-ocm-2.10    #6805   +/-   ##
=================================================
  Coverage             68.30%   68.30%           
=================================================
  Files                   236      236           
  Lines                 35105    35112    +7     
=================================================
+ Hits                  23977    23984    +7     
  Misses                 9053     9053           
  Partials               2075     2075           
Flag Coverage Δ
68.30% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/cluster/validator.go 95.49% <100.00%> (-0.22%) ⬇️

... and 2 files with indirect coverage changes

@gamli75
Copy link
Contributor

gamli75 commented Sep 26, 2024

/retest-required

Copy link

openshift-ci bot commented Sep 26, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants